Render the metadata title in Android player controls#4265
Open
fredrifoUni wants to merge 2 commits into
Open
Conversation
freeboub
suggested changes
Nov 5, 2024
freeboub
left a comment
freeboub
left a comment
Collaborator
There was a problem hiding this comment.
This change will impact all client apps, so you need to make it modular:
- first move this code in a dedicated function
- add a boolean field in https://docs.thewidlarzgroup.com/react-native-video/component/props#controlsstyles be be able to configure it dynamically
Collaborator
|
@fredrifoUni I would be happy to merge this soon, can you please have a look to my comment |
Author
These changes were taken directly from our fork, so I don't know if I'll be able to allocate work hours for this unfortunately. I may be able to revisit it after PR-3914 has been merged in. |
github-project-automation
Bot
moved this to To Triage
in React Native Video - Public Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integrates the video title into the Android player controls. This is already automatically handled by iOS through the
source.metadata.titleprop.Note: